Repository navigation
fix(backend): remove dead Crisp unread endpoint - #11995
Merged
kodjima33 merged 1 commit intoAug 22, 2026
Merged
Conversation
Desktop Crisp client is gone; keep /v1/screen-activity/sync on the same router. Record the route in DELIBERATELY_REMOVED_ENDPOINTS. Refs: BasedHardware#11429 Failure-Class: none
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11429.
What changed and why
Remove the retired
GET /v1/crisp/unreadimplementation while preserving the live screen-activity route on the same router. Remove its route-policy entry and record the intentional API removal in the app-client compatibility checker.Product invariants affected
none
How it was verified
PYTHONPATH=backend pytest -q backend/tests/unit/test_desktop_screen_crisp.py— 10 passed, including a route-level assertion that/v1/crisp/unreadis now absent while the screen-activity suite remains green.make preflight— repository PR contracts passed.Failure class (fixes)
Failure-Class: none